On Mon, 2024-09-23 at 11:39 +0300, Eero Tamminen wrote:
Hi,
On 23.9.2024 0.58, John Paul Adrian Glaubitz wrote:
On Mon, 2024-09-23 at 00:48 +0300, Eero Tamminen wrote:
Not having it configured, but crash backtraces going through its IRQ
handling code, is confusing (found while debugging issues in Atari
emulation).
Please rephrase the patch title. The word "drop" has a very specific
meaning in this context, namely removing a feature. I would rather
call it "disable".
Maybe "Call Atari EtherNAT functions only when it's configured in"?
Yes, that's much better. Maybe eben use:
"Call Atari EtherNAT functions only with CONFIG_FOO_BAR enabled"
Also, I think the longer description is slightly hard to parse due to
too much brevity.
Would this be easier to parse?
"Found while debugging emulation problems. EtherNAT functions were
visible in some backtraces, although EtherNAT config option was
disabled, and emulator did not support EtherNAT."
Yes, this is way better to parse. I would add a "the" before "emulator" though.
(This is from many years ago, these patches have been part of Hatari
emulator, I just haven't posted them here before.)
Thanks,
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
