Hi Geert,
On 18.6.2024 10.36, Geert Uytterhoeven wrote:
On Tue, Jun 18, 2024 at 1:47 AM Jeff Johnson <quic_jjohnson@xxxxxxxxxxx> wrote:
With ARCH=m68k, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in arch/m68k/emu/nfblock.o
WARNING: modpost: missing MODULE_DESCRIPTION() in arch/m68k/emu/nfcon.o
Add the missing invocations of the MODULE_DESCRIPTION() macro.
Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>
Thanks for your patch!
--- a/arch/m68k/emu/nfblock.c
+++ b/arch/m68k/emu/nfblock.c
@@ -193,4 +193,5 @@ static void __exit nfhd_exit(void)
module_init(nfhd_init);
module_exit(nfhd_exit);
+MODULE_DESCRIPTION("ARAnyM block device driver");
I think that should be s/ARAnyM/Atari NatFeat/, as I believe NatFeat
is also available on other Atari emulators. See also nfeth.c
FYI:
Atari "Native Features" (NatFeats / NF) is an API "family", originating
from the Aranym emulator project.
While Hatari emulator implements NF sub-APIs that can be used in
debugging & testing (and adds few of its own), of the device drivers, so
far Hatari implements only NF SCSI driver (which proxies SCSI commands
to the host libudev). Rest of the NF device drivers are supported only
by Aranym.
AFAIK no other Atari emulators than these two, support NF APIs.
(I.e. for now this is Aranym-only NF-API, but "Atari NatFeat" is still
better description.)
MODULE_LICENSE("GPL");
diff --git a/arch/m68k/emu/nfcon.c b/arch/m68k/emu/nfcon.c
index 17b2987c2bf5..0ab2e4d08871 100644
--- a/arch/m68k/emu/nfcon.c
+++ b/arch/m68k/emu/nfcon.c
@@ -173,4 +173,5 @@ static void __exit nfcon_exit(void)
module_init(nfcon_init);
module_exit(nfcon_exit);
+MODULE_DESCRIPTION("ARAnyM console driver");
Likewise.
Yes, this is supported also by the Hatari emulator.
- Eero
PS. As to other (Open Source) NF API users than Linux:
* EmuTOS ROMs support few of the NF protocols related to booting,
* HD Driver (hard disk driver for Atari TOS) supports NF SCSI API,
* Atari FreeMiNT kernel modules support several NF devices, and
* fVDI (gfx driver) & OpenGL backends (running under Atari TOS) support
VDI & OpenGL acceleration NF sub-APIs.
Almost all of those APIs are currently supported only by Aranym.
MODULE_LICENSE("GPL");
If you agree, I can make these changes while queuing in the m68k tree
for v6.11.
Gr{oetje,eeting}s,
Geert
