On 6/17/24 13:53, Christoph Hellwig wrote:
On Mon, Jun 17, 2024 at 08:01:04AM +0900, Damien Le Moal wrote:
On 6/13/24 18:39, Christoph Hellwig wrote:
On Tue, Jun 11, 2024 at 02:51:24PM +0900, Damien Le Moal wrote:
+ if (sdkp->device->type == TYPE_ZBC)
Nit: use sd_is_zoned() here ?
Actually - is there much in even keeping sd_is_zoned now that the
host aware support is removed? Just open coding the type check isn't
any more code, and probably easier to follow.
Removing this helper is fine by me.
FYI, I've removed it yesterday, but not done much of the cleanups suggest
here. We should probably do those in a follow up up, uncluding removing
the !ZBC check in sd_zbc_check_zoned_characteristics.
OK. I will send that once your series in queued.
--
Damien Le Moal
Western Digital Research
