Re: [PATCH 07/26] loop: fold loop_update_rotational into loop_reconfigure_limits

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 07/26] loop: fold loop_update_rotational into loop_reconfigure_limits
From: Damien Le Moal <dlemoal@xxxxxxxxxx>
Date: Tue, 11 Jun 2024 15:00:59 +0900
Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Philipp Reisner <philipp.reisner@xxxxxxxxxx>, Lars Ellenberg <lars.ellenberg@xxxxxxxxxx>, Christoph Böhmwalder <christoph.boehmwalder@xxxxxxxxxx>, Josef Bacik <josef@xxxxxxxxxxxxxx>, Ming Lei <ming.lei@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Alasdair Kergon <agk@xxxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Mikulas Patocka <mpatocka@xxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Yu Kuai <yukuai3@xxxxxxxxxx>, Vineeth Vijayan <vneethv@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, linux-m68k@xxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx, nbd@xxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, ceph-devel@xxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-mmc@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, nvdimm@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx
In-reply-to: <20240611051929.513387-8-hch@lst.de>
Organization: Western Digital Research
References: <20240611051929.513387-1-hch@lst.de> <20240611051929.513387-8-hch@lst.de>
User-agent: Mozilla Thunderbird

On 6/11/24 2:19 PM, Christoph Hellwig wrote:

This prepares for moving the rotational flag into the queue_limits and
also fixes it for the case where the loop device is backed by a block
device.

Signed-off-by: Christoph Hellwig <hch@xxxxxx>


Looks good to me.

Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx>

-- 
Damien Le Moal
Western Digital Research

References:
- move features flags into queue_limits
  - From: Christoph Hellwig
- [PATCH 07/26] loop: fold loop_update_rotational into loop_reconfigure_limits
  - From: Christoph Hellwig

Prev by Date: Re: [PATCH 06/26] loop: also use the default block size from an underlying block device
Next by Date: Re: [PATCH 05/26] loop: regularize upgrading the lock size for direct I/O
Previous by thread: [PATCH 07/26] loop: fold loop_update_rotational into loop_reconfigure_limits
Next by thread: Re: [PATCH 07/26] loop: fold loop_update_rotational into loop_reconfigure_limits
Index(es):
- Date
- Thread

[Index of Archives] [Video for Linux] [Yosemite News] [Linux S/390] [Linux Kernel] [Linux SCSI]