Re: [PATCH 0/1] amiga: turn off all incoming interrupts from the Warp1260

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Paolo,

just a style comment: For a single patch, --compose is  not necessary. Please place the below patch description in the commit message of your patch.

You left the commit message itself empty (aside from your Signed-off-by:). As a result, your patch would go in without any message (unless there's something in b4 that treats single patch submissions with introductory message special).

The commit message usually contains a description of the bug you are fixing. In your case that would be:

Amiga 1200 boot crashes in local_irq_enable() (or auto_irq_enable()) with an interrupt storm. The Warp1260 board interrupts appear to still be active at boot time.

Then a description of what your patch does (which you have below).

You also want a

Link: https://lore.kernel.org/r/ZkjwzVwYeQtyAPrL@amaterasu.local

and

Cc: stable<stable@xxxxxxxxxx>

above your Signed-off-by: tag

Cheers,

    Michael


On 30/05/24 04:31, Paolo Pisati wrote:
The CS-Lab people told me where to find the interrupt ctrl register (and its
layout), so here is a patch that turn off all incoming interrupts during
config.c::amiga_parse_bootinfo().

With this patch applied, Linux finally boots on my Amiga 1200 + Warp 1260 board.

Paolo Pisati (1):
   m68k: amiga: config: upon boot, turn off all incoming interrupts from
     the Warp1260

  arch/m68k/amiga/config.c       | 9 +++++++++
  include/uapi/linux/zorro_ids.h | 3 +++
  2 files changed, 12 insertions(+)





[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux