Re: [PATCH RFC v2 1/2] m68k: Handle __generic_copy_to_user faults more carefully

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Finn,

Am 26.04.2024 um 19:57 schrieb Finn Thain:

On Fri, 26 Apr 2024, Michael Schmitz wrote:

Similar tests with start address five or six bytes before the start of
the unmapped page, and corresponding path length to be returned by
getcwd have shown no more Oops on 030 using the attached corrected
version of my patch.

Please give that some testing if you can, and (hoping it won't show any
new faults on 040) I'll post another version of the series with your
Tested-by added.


I will test it tomorrow. I expect that a NOP is needed at the end of
__clear_user.

Thanks! I'll add __clear_user at the start of __generic_copy_to_user for my tests to check that.

BTW, since you're changing this line, I think there should be a tab here
rather than two spaces:

+               "11:    "MOVES".b  %3,(%2)+\n"

Well spotted - I'll change that while I'm at it.

Cheers,

	Michael




[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux