On Thu, 4 Apr 2024, Andy Shevchenko wrote:
...
First of all, please read this
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#backtraces-in-commit-messages
and amend the commit message accordingly.
Right -- the call chain is described in the commit log message so the
backtrace does not add value. And the timestamps, stack dump etc. are
irrelevant.
Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx>
Cc: Nicholas Piggin <npiggin@xxxxxxxxx>
Cc: Christophe Leroy <christophe.leroy@xxxxxxxxxx>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@xxxxxxxxxx>
Cc: "Naveen N. Rao" <naveen.n.rao@xxxxxxxxxxxxx>
Cc: linux-m68k@xxxxxxxxxxxxxxxxxxxx
Second, please move these Cc to be after the '---' line
I thought they were placed above the line for audit (and signing)
purposes. There are thousands of Cc lines in the mainline commit messages
since v6.8.
Link: https://github.com/vivier/qemu-m68k/issues/44
Link: https://lore.kernel.org/all/1078874617.9746.36.camel@gaston/
Missed Fixes tag?
Would this be ok: Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
I have to ask because some reviewers do not like to see a Fixes tag cite
that commit.
Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxx>
---
(here is a good location for Cc:)
Documentation/process/submitting-patches.rst indicats that it should be
above the "---" separator together with Acked-by etc. Has this convention
changed recently?
Thanks for your review.
