Re: [PATCH 06/52] m68k: kernel: Add and use "process.h"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

On Mon, Sep 11, 2023 at 3:42 PM Greg Ungerer <gerg@xxxxxxxxxxxxxx> wrote:
Nice cleanups. My plan is to clean up the ColdFire/68000 warnings as well.

Thanks in advance!

On 7/9/23 23:41, Geert Uytterhoeven wrote:
--- a/arch/m68k/kernel/process.c
+++ b/arch/m68k/kernel/process.c
@@ -38,6 +38,7 @@
  #include <asm/machdep.h>
  #include <asm/setup.h>

+#include <process.h>

I applied all 52 patches to linux-6.6-rc1 and see this:

     $ ARCH=m68k CROSS_COMPILE=m68k-linux- make amiga_defconfig
     $ ARCH=m68k CROSS_COMPILE=m68k-linux- make W=1
     ...
       CC      arch/m68k/kernel/process.o
     arch/m68k/kernel/process.c:41:10: fatal error: process.h: No such file or directory
      #include <process.h>
               ^~~~~~~~~~~

Of course trivially fixed by doing this:

diff --git a/arch/m68k/kernel/process.c b/arch/m68k/kernel/process.c
index d2d6a5735650..2584e94e2134 100644
--- a/arch/m68k/kernel/process.c
+++ b/arch/m68k/kernel/process.c
@@ -38,7 +38,7 @@
  #include <asm/machdep.h>
  #include <asm/setup.h>

-#include <process.h>
+#include "process.h"

Thanks, will fix (and any other similar typos, if any).

I usually build in separate output directories, which causes

    -I${srcdir}/include
    -I${srcdir}/arch/m68k/kernel
    -I./arch/m68k/kernel

to be added to the include path, causing <...> to work as well :-(

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux