Hi Sergey,
Am 21.08.2023 um 07:19 schrieb Michael Schmitz:
diff --git a/drivers/ata/pata_falcon.c b/drivers/ata/pata_falcon.c
index 996516e64f13..346259e3bbc8 100644
--- a/drivers/ata/pata_falcon.c
+++ b/drivers/ata/pata_falcon.c
@@ -123,8 +123,8 @@ static int __init pata_falcon_init_one(struct
platform_device *pdev)
struct resource *base_res, *ctl_res, *irq_res;
struct ata_host *host;
struct ata_port *ap;
- void __iomem *base;
- int irq = 0;
+ void __iomem *base, *ctl_base;
+ int irq = 0, io_offset = 1, reg_scale = 4;
Maybe reg_step?
Could name it that, too. I can't recall where I picked up the term
'register scaling'...
I'll see what's the consensus (if any) in drivers/.
I've seen some use of 'step' but mostly use of 'shift'.
Rewriting pata_falcon_init_one() to use register shift instead of
register step is trivial, so unless anyone objects, I'll send that
version as v4.
Cheers,
Michael
Cheers,
Michael
[...]
MBR, Sergey
