Hi Zhenggang,
On Sat, Jul 8, 2023 at 6:06 PM <xuanzhenggang001@xxxxxxxxxx> wrote:
Fix the following warnings reported by checkpatch:
./arch/m68k/q40/q40ints.c:172: WARNING: Prefer 'unsigned int' to bare
use of 'unsigned'
./arch/m68k/q40/q40ints.c:211: WARNING: Prefer 'unsigned int' to bare
use of 'unsigned'
Signed-off-by: Zhenggang Xuan <xuanzhenggang001@xxxxxxxxxx>
Thanks for your patch!
But obviously you forgot to run scripts/checkpatch.pl on your own patch:
WARNING: From:/Signed-off-by: email name mismatch: 'From:
xuanzhenggang001@xxxxxxxxxx' != 'Signed-off-by: Zhenggang Xuan
<xuanzhenggang001@xxxxxxxxxx>'
--- a/arch/m68k/q40/q40ints.c
+++ b/arch/m68k/q40/q40ints.c
@@ -169,7 +169,7 @@ void q40_sched_init (void)
*
*/
-struct IRQ_TABLE{ unsigned mask; int irq ;};
+struct IRQ_TABLE { unsigned int mask ; int irq ; };
#if 0
static struct IRQ_TABLE iirqs[]={
{Q40_IRQ_FRAME_MASK,Q40_IRQ_FRAME},
@@ -208,7 +208,7 @@ static int aliased_irq; /* how many times
inside handler ?*/
/* got interrupt, dispatch to ISA or keyboard/timer IRQs */
static void q40_irq_handler(unsigned int irq, struct pt_regs *fp)
{
- unsigned mir, mer;
+ unsigned int mir, mer;
This part is white-space damaged, and thus fails to apply.
int i;
//repeat:
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
