On Thu, Jun 15, 2023 at 01:34:25PM +1000, Michael Ellerman wrote:
Eric DeVolder <eric.devolder@xxxxxxxxxx> writes:
-config KEXEC_FILE
- bool "kexec file based system call"
- select KEXEC_CORE
- select HAVE_IMA_KEXEC if IMA
- select KEXEC_ELF
- depends on PPC64
- depends on CRYPTO=y
- depends on CRYPTO_SHA256=y
...
+
+config ARCH_HAS_KEXEC_FILE
+ def_bool PPC64 && CRYPTO && CRYPTO_SHA256
The =y's got lost here.
I think they were both meaningful, because both options are tristate. So
this previously required them to be built-in (=y), whereas after your
patch it will allow them to be modules.
I don't know for sure that those options need to be built-in, but that's
what the code does now, so this patch shouldn't change it, at least
without an explanation.
This patch shouldn't change it at all, period. If you want to change it
(and that sounds like a good idea, if it is possible anyway), that
should be a separate patch.
Segher
