Hi Yonggang,
Thanks for your patch!
On Wed, Jun 14, 2023 at 8:16 AM <wuyonggang001@xxxxxxxxxx> wrote:
Fix the following checkpatch error:
The patch subject does not match the description.
ERROR: space required after that ',' (ctx:VxV)
ERROR: spaces required around that '<' (ctx:VxV)
Signed-off-by: Yonggang Wu <wuyonggang001@xxxxxxxxxx>
scripts/checkpatch.pl says:
WARNING: From:/Signed-off-by: email name mismatch: 'From:
wuyonggang001@xxxxxxxxxx' != 'Signed-off-by: Yonggang Wu
<wuyonggang001@xxxxxxxxxx>'
--- a/arch/m68k/q40/config.c
+++ b/arch/m68k/q40/config.c
@@ -270,7 +270,7 @@ static int q40_set_rtc_pll(struct rtc_pll_info *pll)
if (!pll->pll_ctrl) {
/* the docs are a bit unclear so I am doublesetting */
/* RTC_WRITE here ... */
- int tmp = (pll->pll_value & 31) | (pll->pll_value<0 ? 32 : 0) |
+ int tmp = (pll->pll_value & 31) | (pll->pll_value < 0 ? 32 : 0)
|
ERROR: patch seems to be corrupt (line wrapped?)
Q40_RTC_WRITE;
Q40_RTC_CTRL |= Q40_RTC_WRITE;
Q40_RTC_CTRL = tmp;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
