Hi Finn,
On Mon, May 15, 2023 at 11:44 AM Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
On Wed, Apr 5, 2023 at 6:19 AM Finn Thain <fthain@xxxxxxxxxxxxxx> wrote:
Some Nubus card ROMs contain many slot resources. A single Radius video
card produced well over a thousand entries under /proc/bus/nubus/.
Populating /proc/bus/nubus/ on a slow machine with several such cards
installed takes long enough that the user may think that the system is
wedged. All those procfs entries also consume significant RAM though
they are not normally needed (except by developers).
Omit these resources from /proc/bus/nubus/ by default and add a kernel
parameter to enable them when needed.
On the test machine, this saved 300 kB and 10 seconds.
Cc: Brad Boyer <flar@xxxxxxxxxxxxx>
Tested-by: Stan Johnson <userm57@xxxxxxxxx>
Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxx>
---
Changed since v3:
- Better commentary.
Changed since v2:
- Added commentary.
- Moved declaration to nubus.h.
Changed since v1:
- Expanded to cover all slot resources in procfs.
Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
i.e. will queue in the m68k for-v6.5 branch.
Upon second look, "populate_procfs" is too generic for a global
variable. Please add a "nubus_"-prefix, and use module_param_named()
instead.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
