On Mon 2022-10-31 17:05:54, John Ogness wrote:
On 2022-10-21, Petr Mladek <pmladek@xxxxxxxx> wrote:
diff --git a/arch/m68k/emu/nfcon.c b/arch/m68k/emu/nfcon.c
index 557d60867f98..c542fc2b121f 100644
--- a/arch/m68k/emu/nfcon.c
+++ b/arch/m68k/emu/nfcon.c
@@ -151,7 +151,7 @@ static int __init nfcon_init(void)
nfcon_tty_driver = driver;
- if (!(nf_console.flags & CON_ENABLED))
+ if (!console_is_enabled(&nf_console))
Heh, the check of CON_ENABLED does not make much sense. IMHO, the
important thing is whether the console is in console_list or not.
I would personally add a check at the beginning of register_console()
whether the console is already registered and enabled() and do
nothing when already done.
Actually, register_console() already has this check, but it does a
WARN(). If the debug setup is used for nfcon, this situation is
normal.
I see.
So probably to avoid the WARN, the CON_ENABLED code was added.
I though more about it. I would keep the warning for the case
when the 2nd registration is not intentional.
This driver has two ways how the console can be registered.
It can happen either in nfcon_init() or in nf_debug_setup().
It is better to have an explicit check to show that it is intentional.
I would be nice to fix this. But it might be done later.
I could add a console_is_registered() function that checks if the
console is in the console list and use that instead. If we are going to
touch this code, we might as well touch it correctly, right?
It would be great. It is actually much easier after switching
to the hlist.
Best Regards,
Petr
