Re: [PATCH linux-next] m68k: Move from strlcpy with unused retval to strscpy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



CC linux-m68k

On Fri, Sep 30, 2022 at 10:07 AM <cgel.zte@xxxxxxxxx> wrote:
From: Xu Panda <xu.panda@xxxxxxxxxx>

The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL terminated strings.

Reported-by: Zeal Robot <zealci@xxxxxxxxxx>
Signed-off-by: Xu Panda <xu.panda@xxxxxxxxxx>
---
 arch/m68k/kernel/setup_mm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/m68k/kernel/setup_mm.c b/arch/m68k/kernel/setup_mm.c
index 06ee394db610..401a8deb6ffc 100644
--- a/arch/m68k/kernel/setup_mm.c
+++ b/arch/m68k/kernel/setup_mm.c
@@ -231,7 +231,7 @@ void __init setup_arch(char **cmdline_p)
        setup_initial_init_mm((void *)PAGE_OFFSET, _etext, _edata, _end);

 #if defined(CONFIG_BOOTPARAM)
-       strncpy(m68k_command_line, CONFIG_BOOTPARAM_STRING, CL_SIZE);
+       strscpy(m68k_command_line, CONFIG_BOOTPARAM_STRING, CL_SIZE);
        m68k_command_line[CL_SIZE - 1] = 0;
 #endif /* CONFIG_BOOTPARAM */
        process_uboot_commandline(&m68k_command_line[0], CL_SIZE);
--
2.15.2



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux