Re: [PATCH qemu v2 2/2] m68k: align bootinfo strings and data to 4 bytes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 26, 2022 at 11:42:37PM +0200, Jason A. Donenfeld wrote:
On Mon, Sep 26, 2022 at 11:42 PM Laurent Vivier <laurent@xxxxxxxxx> wrote:

Le 26/09/2022 à 23:40, Jason A. Donenfeld a écrit :
On Mon, Sep 26, 2022 at 11:37 PM Laurent Vivier <laurent@xxxxxxxxx> wrote:

Le 26/09/2022 à 13:39, Jason A. Donenfeld a écrit :
Various tools, such as kexec-tools and m68k-bootinfo, expect each
bootinfo entry to be aligned to 4 bytes, not 2 bytes. So adjust the
padding to fill this out as such.

Also, break apart the padding additions from the other field length
additions, so that it's more clear why these magic numbers are being
added, and comment them too.

Reported-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Cc: Laurent Vivier <laurent@xxxxxxxxx>
Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx>
---
   hw/m68k/bootinfo.h | 10 ++++++----
   1 file changed, 6 insertions(+), 4 deletions(-)


Applied to my m68k-for-7.2 branch

What about 1/2?


I'd like to wait a little to see what happens on the linux side.

Alright, makes sense. Just please don't forget about it.

Okay, all set. Uneventful.
https://git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k.git/commit/?id=f1bb20c8be1929743fdb313b4770601afc39c1b7

Jason




[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux