Re: [PATCH] m68k/mac: Fixed duplicate "in" in comments.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Xin,

On Wed, Jul 20, 2022 at 12:55 PM Xin Gao <gaoxin@xxxxxxxxxx> wrote:
Fixed duplicate "in" in comments.

Signed-off-by: Xin Gao <gaoxin@xxxxxxxxxx>

Thanks for your patch!

--- a/arch/m68k/mac/misc.c
+++ b/arch/m68k/mac/misc.c
@@ -126,7 +126,7 @@ static void via_rtc_send(__u8 data)

        reg = via1[vBufB] & ~(VIA1B_vRTCClk | VIA1B_vRTCData);

-       /* The bits of the byte go in in MSB order */
+       /* The bits of the byte go in MSB order */

The original was correct.
Ask yourself the question: "How should the bits go in?"
"In MSB order".


        for (i = 0 ; i < 8 ; i++) {
                bit = data & 0x80? 1 : 0;

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux