On Mon, Apr 11, 2022 at 10:53:39AM +0200, Geert Uytterhoeven wrote:
Hi Greg,
On Thu, Apr 7, 2022 at 8:18 AM Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
On Thu, Apr 07, 2022 at 08:00:08AM +0200, Laurent Vivier wrote:
Le 07/04/2022 à 06:48, Greg KH a écrit :
On Wed, Apr 06, 2022 at 10:15:20PM +0200, Laurent Vivier wrote:
Revert
commit da31de35cd2f ("tty: goldfish: use __raw_writel()/__raw_readl()")
and define gf_ioread32()/gf_iowrite32() to be able to use accessors
defined by the architecture.
Cc: stable@xxxxxxxxxxxxxxx # v5.11+
Fixes: da31de35cd2f ("tty: goldfish: use __raw_writel()/__raw_readl()")
Signed-off-by: Laurent Vivier <laurent@xxxxxxxxx>
Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
---
drivers/tty/goldfish.c | 20 ++++++++++----------
include/linux/goldfish.h | 15 +++++++++++----
2 files changed, 21 insertions(+), 14 deletions(-)
Why is this a commit for the stable trees? What bug does it fix? You
did not describe the problem in the changelog text at all, this looks
like a housekeeping change only.
Arnd asked for that in:
Re: [PATCH v11 2/5] tty: goldfish: introduce gf_ioread32()/gf_iowrite32()
https://lore.kernel.org/lkml/CAK8P3a1oN8NrUjkh2X8jHQbyz42Xo6GSa=5n0gD6vQcXRjmq1Q@xxxxxxxxxxxxxx/
You did not provide a reason in this changelog to explain any of that :(
OK if I queue that patch with the rationale from Arnd's email added
to the patch description?
Fine with me, merge away!
