On Tue, Mar 22, 2022 at 03:30:22PM +0100, Geert Uytterhoeven wrote:
Hi Kees, On Thu, Feb 24, 2022 at 9:12 AM Kees Cook <keescook@xxxxxxxxxxxx> wrote:Convert to running under Kunit (and retain being able to run stand-alone too). Building under Clang (or GCC 12) with CONFIG_INIT_STACK_ALL_ZERO=y, this now passes as expected: $ ./tools/testing/kunit/kunit.py config --make_option LLVM=1 $ ./tools/testing/kunit/kunit.py run overflow --make_option LLVM=1 \ --kconfig_add CONFIG_INIT_STACK_ALL_ZERO=y ...Signed-off-by: Kees Cook <keescook@xxxxxxxxxxxx>Thanks for your patch, which is now commit 02788ebcf521fe78 ("lib: stackinit: Convert to KUnit") upstream. Out of curiosity, I gave this a try on m68k, and it still seems to fail the same way of before[1]: [...] [1] https://lore.kernel.org/r/CAMuHMdW6N40+0gGQ+LSrN64Mo4A0-ELAm0pR3gWQ0mNanyBuUQ@xxxxxxxxxxxxxx
Ah yes! Thanks for the reminder. I will take a look at this. Clearly, it's an issue with memory layout assumptions that don't match on m68k, etc. -- Kees Cook
