Hi Joe,
thanks for your review!
On 19/11/21 08:18, Joe Perches wrote:
On Mon, 2021-11-15 at 12:40 +1300, Michael Schmitz wrote:
Add module parameter, IO mode autoprobe and PCMCIA reset code
required to support 100 Mbit PCMCIA ethernet cards on Amiga.
[]
diff --git a/drivers/net/ethernet/8390/apne.c b/drivers/net/ethernet/8390/apne.c
[]
@@ -119,6 +119,48 @@ static u32 apne_msg_enable;
[]
+ cftuple_len = pcmcia_copy_tuple(CISTPL_CFTABLE_ENTRY, cftuple, 256);
+ if (cftuple_len < 3)
+ return 0;
+#ifdef DEBUG
+ else
+ print_hex_dump(KERN_WARNING, "cftable: ", DUMP_PREFIX_NONE, 8,
+ sizeof(char), cftuple, cftuple_len, false);
+#endif
Why KERN_WARNING and why not use print_hex_dump_debug without the #ifdef
No particular reason - head still stuck in the '90 perhaps.
[]
+#ifdef DEBUG
+ pr_info("IO flags: %x\n", cftable_entry.io.flags);
pr_debug ?
Both changed now, thanks!
Regards,
Michael Schmitz
