Hi Randy,
On 09/11/21 18:44, Randy Dunlap wrote:
On 11/8/21 8:55 PM, Michael Schmitz wrote:
Hi Randy,
On 09/11/21 17:09, Randy Dunlap wrote:
On 11/8/21 8:02 PM, Michael Schmitz wrote:
diff --git a/drivers/net/ethernet/8390/Kconfig
b/drivers/net/ethernet/8390/Kconfig
index a4130e643342..b22c3cf96560 100644
--- a/drivers/net/ethernet/8390/Kconfig
+++ b/drivers/net/ethernet/8390/Kconfig
@@ -136,6 +136,8 @@ config NE2K_PCI
config APNE
tristate "PCMCIA NE2000 support"
depends on AMIGA_PCMCIA
+ select PCCARD
+ select PCMCIA
select CRC32
Hi,
There are no other drivers that "select PCCARD" or
"select PCMCIA" in the entire kernel tree.
I don't see any good justification to allow it here.
Amiga doesn't use anything from the core PCMCIA code, instead
providing its own basic PCMCIA support code.
I had initially duplicated some of the cis tuple parser code, but
decided to use what's already there instead.
I can drop these selects, and add instructions to manually select
these options in the Kconfig help section. Seemed a little error prone
to me.
Just make it the same as other drivers in this respect, please.
"depends on PCMCIA" is what I've seen for other drivers. That is not
really appropriate for the APNE driver (8 bit cards work fine with just
the support code from arch/m68k/amiga/pcmcia.c).
Please confirm that "depends on PCMCIA" is what you want me to use?
Cheers,
Michael
