On Fri, Oct 15, 2021 at 12:32 AM Eugene Syromiatnikov <esyr@xxxxxxxxxx> wrote:
On Thu, Jul 29, 2021 at 10:20:42AM +0800, Jeremy Kerr wrote:
This change introduces the user-visible MCTP header, containing the
protocol-specific addressing definitions.
[...]
--- a/include/uapi/linux/mctp.h
+++ b/include/uapi/linux/mctp.h
@@ -9,7 +9,28 @@
#ifndef __UAPI_MCTP_H
#define __UAPI_MCTP_H
+#include <linux/types.h>
+
+typedef __u8 mctp_eid_t;
+
+struct mctp_addr {
+ mctp_eid_t s_addr;
+};
+
struct sockaddr_mctp {
+ unsigned short int smctp_family;
This gap makes the size of struct sockaddr_mctp 2 bytes less at least
on m68k, are you fine with that?
+ int smctp_network;
+ struct mctp_addr smctp_addr;
+ __u8 smctp_type;
+ __u8 smctp_tag;
And it may be wise to add 1 byte of explicit padding here?
Or is there a good reason not to do so?
};
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
