Re: [PATCH v4 5/5] bus: Make remove callback return void

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 13, 2021 at 09:35:22PM +0200, Uwe Kleine-König wrote:
The driver core ignores the return value of this callback because there
is only little it can do when a device disappears.

This is the final bit of a long lasting cleanup quest where several
buses were converted to also return void from their remove callback.
Additionally some resource leaks were fixed that were caused by drivers
returning an error code in the expectation that the driver won't go
away.

With struct bus_type::remove returning void it's prevented that newly
implemented buses return an ignored error code and so don't anticipate
wrong expectations for driver authors.

Acked-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx> (For ARM, Amba and related parts)
Acked-by: Mark Brown <broonie@xxxxxxxxxx>
Acked-by: Chen-Yu Tsai <wens@xxxxxxxx> (for sunxi-rsb)
Acked-by: Pali Rohár <pali@xxxxxxxxxx>
Acked-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> (for media)
Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx> (For drivers/platform)
Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
Acked-By: Vinod Koul <vkoul@xxxxxxxxxx>
Acked-by: Juergen Gross <jgross@xxxxxxxx> (For xen)
Acked-by: Lee Jones <lee.jones@xxxxxxxxxx> (For mfd)
Acked-by: Johannes Thumshirn <jth@xxxxxxxxxx> (For mcb)
Acked-by: Johan Hovold <johan@xxxxxxxxxx>
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> (For slimbus)
Acked-by: Kirti Wankhede <kwankhede@xxxxxxxxxx> (For vfio)
Acked-by: Maximilian Luz <luzmaximilian@xxxxxxxxx>
Acked-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> (For ulpi and typec)
Acked-by: Samuel Iglesias Gonsálvez <siglesias@xxxxxxxxxx> (For ipack)
Reviewed-by: Tom Rix <trix@xxxxxxxxxx> (For fpga)
Acked-by: Geoff Levand <geoff@xxxxxxxxxxxxx> (For ps3)
Acked-by: Yehezkel Bernat <YehezkelShB@xxxxxxxxx> (For thunderbolt)
Reviewed-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
Acked-by: Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx> (For intel_th)
Acked-by: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx> (For pcmcia)
Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx> (For drivers/s390 and drivers/vfio)
Acked-by: Rafael J. Wysocki <rafael@xxxxxxxxxx> (For ACPI)
Acked-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> (rpmsg and apr)
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx> (For intel-ish-hid)
Acked-by: Dan Williams <dan.j.williams@xxxxxxxxx> (For CXL, DAX, and NVDIMM)
Acked-by: William Breathitt Gray <vilhelm.gray@xxxxxxxxx> (For isa)
Acked-by: Stefan Richter <stefanr@xxxxxxxxxxxxxxxxx> (For firewire)
Acked-by: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> (For hid)
Acked-by: Thorsten Scherer <t.scherer@xxxxxxxxxxxx> (For siox)
Acked-by: Sven Van Asbroeck <TheSven73@xxxxxxxxx> (For anybuss)
Acked-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> (For MMC)
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Acked-by: Wolfram Sang <wsa@xxxxxxxxxx> # for I2C

Thanks, Uwe!

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux