Hi Christoph,
Am 09.07.2021 um 16:22 schrieb Christoph Hellwig:
On Fri, Jul 09, 2021 at 12:31:45PM +1200, Michael Schmitz wrote:
That patch works fine on a casual test. What you did to
__constant_copy_to_user() does not appear to matter - but I haven't put the
system under any kind of stress yet. I'm a little reluctant to do that
(recovering from a trashed boot disk is a little dicey), I'll probably only
try that with your changes to __constant_copy_to_user() from commit
d36105c942e0 backed out.
As Linus pointed out, small copy_to_user basically doesn't happen as
we have switched all the suspect call sites to just use put_user.
Thanks, I missed that. That does explain it then.
I see you've put a warning message in set_fc() - let's see whether that
triggers on a test run on real hardware.
Cheers,
Michael
Geert: do you care about __constant_copy_to_user at all, or can we just
kill it (as well as the copy_from_user side)?
