Re: [PATCH v6 1/2] m68k/kernel - wire up syscall_trace_enter/leave for m68k

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert, Greg,

no matter - I managed to at least get entry.S to 'compile' for 68000, even though the final link failed.

I'm reasonably certain that 'ret_from_exception' is the correct branch target if a syscall is to be skipped, but I'd like to have that double checked?

Cheers,

	Michael

Am 29.06.2021 um 19:35 schrieb Greg Ungerer:
Hi Michael, Geert,

On 29/6/21 5:31 pm, Geert Uytterhoeven wrote:
Hi Michael,

On Tue, Jun 29, 2021 at 12:16 AM Michael Schmitz
<schmitzmic@xxxxxxxxx> wrote:
On 28/06/21 7:25 pm, Geert Uytterhoeven wrote:
On Thu, Jun 24, 2021 at 2:46 AM Michael Schmitz
<schmitzmic@xxxxxxxxx> wrote:
m68k (other than Coldfire) uses syscall_trace for both trace entry
and trace exit. Seccomp support requires separate entry points for
trace entry and exit which are already provided for Coldfire.

Replace syscall_trace by syscall_trace_enter and syscall_trace_leave
in preparation for seccomp support. Check return code of
syscall_trace_enter(), and skip syscall if -1. Return code will be
left at what had been set by ptrace or seccomp (in regs->d0).

No regression seen in testing with strace on ARAnyM.

Signed-off-by: Michael Schmitz <schmitzmic@xxxxxxxxx>
b
Thanks for your patch!

   arch/m68k/kernel/entry.S  |  8 +++++---
We need similar changes to arch/m68k/68000/entry.S and
arch/m68k/coldfire/entry.S

Do you have a current defconfig for 68000? I've test compiled my patch
with two coldfire defconfigs, but could not find one for m68kclassic ...

Unfortunately not.
Greg?

Sorry, no, I don't have one.
Whenever I need to compile for a 68000 target I manually configure one
("make menuconfig" and friends).

Would be nice to have one in mainline ;-)

Regards
Greg




[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux