Re: [PATCH RFC 2/2] net/8390: apne.c - add 100 Mbit support to apne.c driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Alex has been testing the patch for me, but had to resort to hardcoding the kernel option (or isa_type).

How would this option be specified on the kernel command line?

I would have thought apne:apne_100_mbit=1 would set that variable to 1?

There's been other issues with the patch as well, this appears to need a bit more work.

Cheers,

    Michael

On 8/06/21 12:56 am, Geert Uytterhoeven wrote:
Hi Michael,

On Sun, Jun 6, 2021 at 7:54 AM Michael Schmitz <schmitzmic@xxxxxxxxx> wrote:
Add Kconfig option, module parameter and PCMCIA reset code
required to support 100 Mbit PCMCIA ethernet cards on Amiga.

10 Mbit and 100 Mbit mode are supported by the same module.
A module parameter switches Amiga ISA IO accessors to word
access by changing isa_type at runtime. Additional code to
reset the PCMCIA hardware is also added to the driver probe.

Patch modified after patch "[PATCH RFC net-next] Amiga PCMCIA
100 MBit card support" submitted to netdev 2018/09/16 by Alex
Kazik <alex@xxxxxxxx>.

Signed-off-by: Michael Schmitz <schmitzmic@xxxxxxxxx>
--- a/drivers/net/ethernet/8390/apne.c
+++ b/drivers/net/ethernet/8390/apne.c
@@ -120,6 +120,10 @@ static u32 apne_msg_enable;
  module_param_named(msg_enable, apne_msg_enable, uint, 0444);
  MODULE_PARM_DESC(msg_enable, "Debug message level (see linux/netdevice.h for bitmap)");

+static u32 apne_100_mbit;
+module_param_named(apne_100_mbit, uint, 0);
error: macro "module_param_named" requires 4 arguments, but only 3 given

Gr{oetje,eeting}s,

                         Geert




[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux