On Mon, 7 Jun 2021, Michael Schmitz wrote:
Hi Finn, are there any substantial changes from what I'd tested before?
The request_region() stuff is new, and I reworked the host->get_lock and host->release_lock changes. So you may want to review it again.
Your patch conflicts with (I think) the Mac IDE patches now in Geert's tree, and I'd rather avoid hand-patching the lot if at all possible: m68k_q40_Replace_q40ide_with_pata_falcon_and_falconide Applying: m68k/q40: Replace q40ide with pata_falcon and falconide error: patch failed: arch/m68k/configs/multi_defconfig:351 error: arch/m68k/configs/multi_defconfig: patch does not apply error: patch failed: drivers/ide/Kconfig:731 error: drivers/ide/Kconfig: patch does not apply error: patch failed: drivers/ide/Makefile:29 error: drivers/ide/Makefile: patch does not apply
I should have sent these as a two-part series. Sorry about that. You'll need to apply this patch first: https://lore.kernel.org/linux-ide/3de9a93d-2f7-a650-1fa-c2129a4a765b@nippy.intranet/T/
What's your baseline for this patch?
I've used v5.12 and v5.13-rc5, but mostly I develop on the mac68k branch in my github repository.
(In the alternative: just add my Tested-by if nothing changed aside from the IO region reservation)
I have tested these patches in Aranym (including a multi-platform atari/q40 build which required your ISA fix) but I don't have any way to test the q40-only code.
