Re: [PATCH 07/15] m68k: convert to setup_initial_init_mm()

[Greg Ungerer <gerg@xxxxxxxxxxxxxx>]

On 31/5/21 5:48 pm, Geert Uytterhoeven wrote:
> Hi Kefeng
>
> (CC Greg for m68knommu)
>
> On Sat, May 29, 2021 at 12:46 PM Kefeng Wang <wangkefeng.wang@xxxxxxxxxx> wrote:
> > Use setup_initial_init_mm() helper to simplify code.
> >
> > Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> > Cc: linux-m68k@xxxxxxxxxxxxxxxxxxxx
> > Signed-off-by: Kefeng Wang <wangkefeng.wang@xxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/arch/m68k/kernel/setup_mm.c
> > +++ b/arch/m68k/kernel/setup_mm.c
> > @@ -258,10 +258,7 @@ void __init setup_arch(char **cmdline_p)
> >                  }
> >          }
> >
> > -       init_mm.start_code = PAGE_OFFSET;
> > -       init_mm.end_code = (unsigned long)_etext;
> > -       init_mm.end_data = (unsigned long)_edata;
> > -       init_mm.brk = (unsigned long)_end;
> > +       setup_initial_init_mm((void *)PAGE_OFFSET, _etext, _edata, _end);
>
> Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>
> > --- a/arch/m68k/kernel/setup_no.c
> > +++ b/arch/m68k/kernel/setup_no.c
> > @@ -87,10 +87,7 @@ void __init setup_arch(char **cmdline_p)
> >          memory_start = PAGE_ALIGN(_ramstart);
> >          memory_end = _ramend;
> >
> > -       init_mm.start_code = (unsigned long) &_stext;
> > -       init_mm.end_code = (unsigned long) &_etext;
> > -       init_mm.end_data = (unsigned long) &_edata;
> > -       init_mm.brk = (unsigned long) 0;
> > +       setup_initial_init_mm(_stext, _etext, _edata, (void *)0);
>
> Please use NULL instead of (void *)0.

With that in place, no problems I see.

Acked-by: Greg Ungerer <gerg@xxxxxxxxxxxxxx>


> Gr{oetje,eeting}s,
>
>                          Geert