On Sun, May 16, 2021 at 6:24 AM Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
On Sun, 16 May 2021, Arnd Bergmann wrote:
From: Arnd Bergmann <arnd@xxxxxxxx>
This driver always warns about unused functions because it includes
an file that it doesn't actually need:
I don't think you can omit #include "lib8390.c" here without changing
driver behaviour, because of the macros in effect.
I think this change would need some actual testing unless you can show
that the module binary does not change.
Michael posted a similar but different patch a while ago, involving
calling ax_NS8390_reinit():
https://lore.kernel.org/linux-m68k/1528604559-972-3-git-send-email-schmitzmic@xxxxxxxxx/
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
