On 28/4/21 12:16 am, Arnd Bergmann wrote:
On Tue, Apr 27, 2021 at 3:49 PM Greg Ungerer <gerg@xxxxxxxxxxxxxx> wrote:
The kernel test robot reports that the "screen_bits" splash screen data
is missing for the dragen platform:
arch/m68k/68000/dragen2.c:73:16: error: 'screen_bits' undeclared (first use in this function)
73 | LSSA = (long) screen_bits;
| ^~~~~~~~~~~
arch/m68k/68000/dragen2.c:73:16: note: each undeclared identifier is reported only once for each function it appears in
Digging around a bit I found the screen_bits data structure was originally
in a screen.h file that was generated from a screen.xbm file. That was
removed in commit 0c0e6db80683 ("m68k: drop unused parts of 68VZ328
Makefile").
Other splash screen initializers for 68000 targets are kept here as the
C data structures so lets do the same for this one. Add the missing
screen.h file and include it in the dragen specific startup code.
Thanks, I certainly appreciate not getting the nag emails from the lkp bot
any more ;-)
You and me both :-)
Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
I also see that it started out like this even in linux-2.5.25 when Alan Cox
originally merged arch/m68knommu, so presumably the platform has
never been used (at least with a screen) after it got merged into mainline.
Reported-by: kernel test robot <lkp@xxxxxxxxx>
Signed-off-by: Greg Ungerer <gerg@xxxxxxxxxxxxxx>>
Note: extra '>' in your signed-off-by line
Oops, yep. I'll fix that before I push it up to the m68knommu git tree
(which won't be for a couple of weeks at least yet).
Regards
Greg
Arnd
