Hi David,
Thank you for your very clear reply!
On 15/04/2021 08:01, David Gow wrote:
On Wed, Apr 14, 2021 at 5:25 PM Matthieu Baerts
<matthieu.baerts@xxxxxxxxxxxx> wrote:
Up to the KUnit maintainers to decide ;-)
To summarise my view: personally, I'd prefer things the way this patch
works: have everything end in _KUNIT_TEST, even if that enables a
couple of suites. The extra 'S' on the end isn't a huge problem if you
have a good reason to particularly want to keep it, though: as long as
you don't have something like _K_UNIT_VERIFICATION or something
equally silly that'd break grepping for '_KUNIT_TEST', it's fine be
me.
Indeed it makes sense: we don't need to split nor to have a meta-Kconfig
entry. We can then remove the extra 'S' and update our tests suite:
Reviewed-by: Matthieu Baerts <matthieu.baerts@xxxxxxxxxxxx>
I see that the whole series has been marked as "Not Applicable" on
Netdev's patchwork:
https://patchwork.kernel.org/project/netdevbpf/patch/0fa191715b236766ad13c5f786d8daf92a9a0cf2.1618388989.git.npache@xxxxxxxxxx/
Like patch 1/6, I can apply it in MPTCP tree and send it later to
net-next with other patches.
Except if you guys prefer to apply it in KUnit tree and send it to
linux-next?
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
