On Tue, Mar 16, 2021 at 09:17:24AM +0100, Rasmus Villemoes wrote:
On 16/03/2021 02.54, Yury Norov wrote:
GENMASK(h, l) may be passed with unsigned types. In such case, type-limits
warning is generated for example in case of GENMASK(h, 0).
...
I don't like that kind of collateral damage. I seem to recall another
instance where a macro was instead rewritten to avoid triggering the
type-limits warning (with a comment explaining the uglyness). Something like
foo > bar is the same as
!(foo <= bar) which is the same as
!(foo == bar || foo < bar)
Dunno if that would work here, but if it did, it would have the bonus
that when somebody builds the kernel proper with Wtype-limits enabled
(maybe W=1 or W=2) there would be no false positives from GENMASK to
wade through.
Alternatively, we really should consider making use of _Pragma to
locally disable/re-enable certain warnings.
Rasmus, in the kernel the same was fixed as per 355a3587d4ca.
I don't know why tools should be different to that.
--
With Best Regards,
Andy Shevchenko
