Re: [PATCH 01/23] kernel: irq: irqdescs: warn on spurious IRQ

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 21, 2020 at 7:44 AM Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote:
Andy Shevchenko <andy.shevchenko@xxxxxxxxx> writes:
On Fri, Dec 18, 2020 at 4:37 PM Enrico Weigelt, metux IT consult
<info@xxxxxxxxx> wrote:

+               if (printk_ratelimit())
+                       pr_warn("spurious IRQ: irq=%d hwirq=%d nr_irqs=%d\n",
+                               irq, hwirq, nr_irqs);

Perhaps you missed pr_warn_ratelimit() macro which is already in the
kernel for a long time.

pr_warn_ratelimited() which calls printk_ratelimited().

I stand corrected.
Right, that's what I had in mind (actually didn't know that there are variants).

Thanks!

And see the comment above printk_ratelimit():

/*
 * Please don't use printk_ratelimit(), because it shares ratelimiting state
 * with all other unrelated printk_ratelimit() callsites.  Instead use
 * printk_ratelimited() or plain old __ratelimit().
 */


-- 
With Best Regards,
Andy Shevchenko



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux