On Thu, Oct 8, 2020 at 5:47 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
When I created the patch removing CONFIG_ARCH_GETTIMEOFFSET, I also had a look at CONFIG_GENERIC_CLOCKEVENTS, which is selected by most, but not all, platforms today, each of the ones that lack it doing the timer tick slightly differently. The cleanups here make the old platforms a bit more consistent, in multiple ways: - rather than selecting GENERIC_CLOCKEVENTS on modern platforms, select LEGACY_TIMER_TICK on the old ones. - Hide some more of the internal implementation and only provide a single common entry point for the timer tick, which also makes the behavior more consistent. - Remove the m68k and arm specific infrastructure pieces and call the common helper directly from each timer interrupt function. I tested the series on m68k with the qemu q800 target platform, both with the legacy_timer_tick() implementation and after converting that to a periodic clockevent driver.
I am a big fan of this patch series: Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Maybe the RFC patch can be kept in the sidelines but the rest should be merged ASAP in my opinion, the kernel just looks so much better after this. Yours, Linus Walleij
