Re: [PATCH] m68knommu: align BSS section to 4-byte boundaries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Philippe,

On 12/10/20 11:34 pm, Philippe De Muyter wrote:
On Mon, Oct 12, 2020 at 02:34:32PM +1000, Greg Ungerer wrote:
The kernel start up code for all of the nommu m68k types expects the
BSS section to be on a 4-byte boundary, and to be a whole number of 32bit
words. The BSS initialization loop sets 32bit sized quantities and has
no provision for odd or unaligned accesses.

Although this has always been the case, in practice the BSS was typically
aligned and sized this way. The problem was first observed after commit

not aligned and sized ... ?

No, I really was saying that it typically worked out that the BSS was
aligned and sized to 4-bytes. So it almost always worked ok.

Perhaps if I reword it to make it clearer:

The BSS copy has always been coded this way, and by luck, the alignment
and size of the BSS has historically worked out to be 4-byte aligned.

Regards
Greg





[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux