Re: [PATCH 05/19] swim: use bdev_check_media_change

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 02, 2020 at 03:30:14PM +0000, Johannes Thumshirn wrote:
Looks good,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@xxxxxxx>

+static int floppy_revalidate(struct gendisk *disk);

Completely unrelated to this series but, this is the 3rd floppy 
driver in the series defining it's own floppy_revalidate() and 
naming it floppy_revalidate().

This makes grepping and reviewing a pain.

Yes, I noticed it as well.  They also use the floppy_ prefix for
various other methods.


---end quoted text---



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux