Gentle ping :) On Sat, Jul 18, 2020 at 07:26:48PM +0300, Mike Rapoport wrote:
From: Mike Rapoport <rppt@xxxxxxxxxxxxx> Hi, It took me a while to get back to this, but better late than never :) These patches replace DISCONTIGMEM with SPARSEMEM on m68k for systems with !SINGLE_MEMORY_CHUNK set. With SPARSEMEM there is a single node for the entire physical memory and to cope with holes in the physical address space it is divided to sections of several megabytes. Each section has it's own memory map which size depends on actual populated memory. The section size of 16M was chosen pretty much arbitrarily as I couldn't find specs for systems with e.g. Zorro memory extensions. Yet, we cannot use smaller sections and still be able to address the entire 4G of the physical memory because the section number is encoded in the page flags and there are only 8 bits available. For systems with several small memory chunks and with small (several megs) holes between them, 16M section size would cause wasted parts in the memory map and it is desirable to allow smaller section size at the expense of limiting the addressable memory. I've hesitated between adding Kconfig option as Finn suggested [1] and other options like SPARSE_VMEMMAP or ARCH_HAS_HOLES_MEMORYMODEL. In the end, I think Kconfig is the simplest one from the implementation point of view and would work fine for people that run mainline kernels on vintage hardware. For the systems with ST-RAM and FastRAM, the switch to SPARSEMEM does not change the limitation that if the kernel is loaded into the FastRam the ST-RAM remains unmapped. It only ensures that if the kernel is loaded in ST-RAM, the memory map is allocated from high physical addresses and then atari/stram.c is able to reserve the frame buffer memory. If the kernel is loaded to FastRAM, the ST-RAM remains unmapped as with DISCONTIGMEM and the atari/stram.c maps it as IOMEM. [1] https://marc.info/?l=linux-m68k&m=156309170500921&w=2 v3 changes: * rebase on the current upstream * alias ARCH_PFN_BASE to m68k_memory[0].addr * add configuration option to allow two variants of section size. v2 changes: * rebase on the current upstream * make ColdFire MMU select SINGLE_MEMORY_CHUNK in Kconfig.cpu Mike Rapoport (3): m68k/mm: make node data and node setup depend on CONFIG_DISCONTIGMEM m68k/mm: enable use of generic memory_model.h for !DISCONTIGMEM m68k/mm: switch from DISCONTIGMEM to SPARSEMEM arch/m68k/Kconfig.cpu | 14 ++++++-- arch/m68k/include/asm/page.h | 2 ++ arch/m68k/include/asm/page_mm.h | 6 +++- arch/m68k/include/asm/sparsemem.h | 8 +++++ arch/m68k/include/asm/virtconvert.h | 2 +- arch/m68k/mm/init.c | 8 ++--- arch/m68k/mm/motorola.c | 64 ++++++++++++++++++++++++++++++------- 7 files changed, 84 insertions(+), 20 deletions(-) create mode 100644 arch/m68k/include/asm/sparsemem.h -- 2.7.4 *** BLURB HERE *** Mike Rapoport (3): m68k/mm: make node data and node setup depend on CONFIG_DISCONTIGMEM m68k/mm: enable use of generic memory_model.h for !DISCONTIGMEM m68k/mm: switch from DISCONTIGMEM to SPARSEMEM arch/m68k/Kconfig.cpu | 23 ++++++++++++++--- arch/m68k/include/asm/page.h | 2 ++ arch/m68k/include/asm/page_mm.h | 7 +++++- arch/m68k/include/asm/virtconvert.h | 2 +- arch/m68k/mm/init.c | 8 +++--- arch/m68k/mm/motorola.c | 39 ++++++++++++++++++++++++++--- 6 files changed, 69 insertions(+), 12 deletions(-) -- 2.26.2
-- Sincerely yours, Mike.
