On Sun, 31 May 2020, Geert Uytterhoeven wrote:
Hi Finn,
On Sun, May 31, 2020 at 1:16 AM Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
This patch series has several bug fixes for the IOP driver and some
improvements to the debug level log messages.
Thanks for your series!
Thanks for your review and for your diligence in the performance of all of
your duties as maintainer.
Geert, please consider pushing these fixes for v5.8, if not the whole
series.
I'm afraid it's a bit too late for that, as I expect the v5.8 merge
window to open tonight.
Well, it's not that important.
Unless the fix is for a regression in v5.7.
AFAICT these bugs are as old as the original driver. But I don't think
that disqualifies them from backporting, which I plan to do that once they
hit mainline.
BTW, how does the issue being fixed manifest itself? That's not clear to
me from the patch description.
The bugs in the iop driver were found by inspection, in the course of
debugging adb-iop driver failures that Stan encountered. It's possible
that the adb-iop driver is not badly affected by these bugs (I don't
know). It's possible that the iop driver bugs are among the reasons why
the swim_iop driver was never stabilized. That driver was removed in
b21a323710e7 ("[PATCH] remove the broken BLK_DEV_SWIM_IOP driver").
