Re: [PATCH v2 06/18] m68k: Replace setup_irq() by request_irq()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 1 Mar 2020, afzal mohammed wrote:

On Sun, Mar 01, 2020 at 10:11:51AM +1100, Finn Thain wrote:
On Sat, 29 Feb 2020, afzal mohammed wrote:

[...] 
Specific to m68k, following changes has been made based on m68 family
;) feedback,


None of my comments were specific to any architecture.

One thing i had in my background, but realize now that didn't express 
anywhere in my mails, in essence what Geert mentioned, i.e. being legacy 
code, i did not give a treatment that would have been given to adding 
new code.

But m68k subthread has been a very lively one and as not many changes, 
felt it was not fair from my side not to handle almost as though it is a 
new code addition.


I took Geert's comments to be architecture agnostic but perhaps I 
misunderstood.

BTW, how do you distinguish between "new code" and "legacy code"?

And why would you choose to do that when you are writing a tree-wide 
semantic patch?



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux