On 12. 02. 20 10:32, Geert Uytterhoeven wrote:
Hi Michal,
On Wed, Feb 12, 2020 at 10:27 AM Michal Simek <michal.simek@xxxxxxxxxx> wrote:
On 12. 02. 20 10:25, Geert Uytterhoeven wrote:
On Wed, Feb 12, 2020 at 10:23 AM Max Filippov <jcmvbkbc@xxxxxxxxx> wrote:
On Wed, Feb 12, 2020 at 1:16 AM Michal Simek <michal.simek@xxxxxxxxxx> wrote:
Generated files are also checked by sparse that's why add newline
to remove sparse (C=1) warning.
The issue was found on Microblaze and reported like this:
./arch/microblaze/include/generated/uapi/asm/unistd_32.h:438:45:
warning: no newline at end of file
Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx>
Reviewed-by: Stefan Asserhall <stefan.asserhall@xxxxxxxxxx>
--- a/arch/m68k/kernel/syscalls/syscallhdr.sh
+++ b/arch/m68k/kernel/syscalls/syscallhdr.sh
@@ -33,4 +33,5 @@ grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | (
printf "#endif\n"
printf "\n"
printf "#endif /* %s */\n" "${fileguard}"
Here there's already \n at the end, so no need for another one?
Thanks! I completely missed that.
So I did fix the original while applying ;-)
I can drop m68k or align with with others. I would prefer to have the
same solution in all these scripts.
Yeah, it makes sense to align as much as possible.
IIRC, the original plan was to consolidate more later.
Note that all other lines are terminated with a "\n" at the end.
The separate 'printf "\n"' is an extra blank line, not the terminator for the
previous line.
Should we also get rid of 'printf "\n"' lines or just keep them as they
are today?
M
