Hi Finn, Op za 9 nov. 2019 om 23:53 schreef Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx>:
On Sat, 9 Nov 2019, Kars de Jong wrote:diff --git a/drivers/scsi/zorro_esp.c b/drivers/scsi/zorro_esp.c index ca8e3abeb2c7..4448567c495d 100644 --- a/drivers/scsi/zorro_esp.c +++ b/drivers/scsi/zorro_esp.c @@ -218,7 +218,7 @@ static int fastlane_esp_irq_pending(struct esp *esp) static u32 zorro_esp_dma_length_limit(struct esp *esp, u32 dma_addr, u32 dma_len) { - return dma_len > 0xFFFF ? 0xFFFF : dma_len; + return dma_len > (1U << 16) ? (1U << 16) : dma_len; }Would it be safer to simply remove this code and leave esp_driver_ops.dma_length_limit == NULL for all board types?
I have considered that, but that version also imposes unneeded limits on crossing a 24-bit address boundary. The Zorro boards don't seem to need this. Kind regards, Kars.
