Hi Michael,
On Wed, Sep 25, 2019 at 5:59 AM Michael Schmitz <schmitzmic@xxxxxxxxx> wrote:
Am 04.09.2019 um 00:44 schrieb Geert Uytterhoeven:
On Tue, Jul 2, 2019 at 12:02 AM Michael Schmitz <schmitzmic@xxxxxxxxx> wrote:
The Atari platform device setup now provides a platform device
for the Falcon IDE interface. Use this in place of the simple platform
device set up in the old pata_falcon probe code.
Signed-off-by: Michael Schmitz <schmitzmic@xxxxxxxxx>
+module_platform_driver_probe(pata_falcon_driver, pata_falcon_init_one);
This doesn't seem to work in the builtin case (e.g. atari_defconfig with
ide replaced by ata): no hard drives are detected.
Due to a dumb naming mismatch between driver and platform code
(shouldn't have rushed this right before going on leave). This would
have made the driver fail in the modular case as well.
I'll fix that along with adding some error checking in the Atari
platform init code.
OK.
Regarding the potential bisection issue with this series - that ought to
be fixed as well by renaming the platform resource to match what the new
driver expects. I'd rather leave the two patches separate so the Atari
platform code one can go through your tree.
No it isn't: the resource is still busy, and probing fails.
Hence I'll merge them.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
