Re: [PATCH v3 3/3] i2c/busses/i2c-icy: Add LTC2990 present on 2019 board revision

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Braces for both blocks. Did you run checkpatch?

I did, and it didn't say anything.

Hmm, strange, does is complain when you use '--strict'?

Turns out I misremembered the CodingStyle as having a corner case
where it doesn't. I'll fix the style - I dislike the above, too ;)

Thanks!

Yes and no. Now that you mention it - the LTC2990 can be at four
addresses (0x4c - 0x4f), and there are jumpers (solder pads) on the
PCB to select its address. Shall I add all 4 addresses to the array?

Yes, please.

It's also possible that there is no LTC2990 at all (because it's hard
to solder at home), and that's why we need to probe for it first. I
believe i2c_new[_client]_device doesn't do probing, but rather assumes
the device to be there. Correct?

Correct. I assumed the sensor is always there. But it is not and can be
at multiple addresses, so updating the array of addresses is the right
thing to do(tm).

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux