Hi Mike, Mike Rapoport <rppt@xxxxxxxxxxxxx> 於 2019年5月2日 週四 下午11:30寫道：
The nds32 implementation of pte_alloc_one_kernel() differs from the generic in the use of __GFP_RETRY_MAYFAIL flag, which is removed after the conversion. The nds32 version of pte_alloc_one() missed the call to pgtable_page_ctor() and also used __GFP_RETRY_MAYFAIL. Switching it to use generic __pte_alloc_one() for the PTE page allocation ensures that page table constructor is run and the user page tables are allocated with __GFP_ACCOUNT. The conversion to the generic version of pte_free_kernel() removes the NULL check for pte. The pte_free() version on nds32 is identical to the generic one and can be simply dropped. Signed-off-by: Mike Rapoport <rppt@xxxxxxxxxxxxx> --- arch/nds32/include/asm/pgalloc.h | 31 ++++--------------------------- 1 file changed, 4 insertions(+), 27 deletions(-)
Thanks for your patch. I'm assuming this is going in along with the rest of the patches, so I'm not going to add it to my tree. Acked-by: Greentime Hu <greentime@xxxxxxxxxxxxx>
