Re: [PATCH] m68k: add ColdFire mcf5441x eDMA platform support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

On Tue, Feb 05, 2019 at 11:34:34AM +1000, Greg Ungerer wrote:
Hi Angelo,

On 5/2/19 1:53 am, Angelo Dureghello wrote:
[snip]
Many thanks.

I think i found an additional non-functional fix is needed:

arch/m68k/coldfire/device.c line 546, edma "id" should be 0 and not 6.

Fixed and tested here, let me know if you can do that too, or i can send
a v2, as you prefer, not a problem.

No problem, I have fixed and re-pushed to m68knommu git tree for-next branch.
Just to double check, the change was this:

--- /tmp/device.c	2019-02-05 11:30:00.875259680 +1000
+++ /home/gerg/src/linux/git/m68knommu/arch/m68k/coldfire/device.c	2019-02-05 11:32:38.248684394 +1000
@@ -542,7 +542,7 @@
 static struct platform_device mcf_edma = {
 	.name			= "mcf-edma",
-	.id			= 6,
+	.id			= 0,
 	.num_resources		= ARRAY_SIZE(mcf_edma_resources),
 	.resource		= mcf_edma_resources,
 	.dev = {


Thanks, perfect, very kind.

Regards
Greg


Regards,
Angelo



[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux