On Mon, Jan 14, 2019 at 01:59:01PM +0100, David Hildenbrand wrote:
The crashkernel is reserved via memblock_reserve(). memblock_free_all() will call free_low_memory_core_early(), which will go over all reserved memblocks, marking the pages as PG_reserved. So manually marking pages as PG_reserved is not necessary, they are already in the desired state (otherwise they would have been handed over to the buddy as free pages and bad things would happen). Cc: Catalin Marinas <catalin.marinas@xxxxxxx> Cc: Will Deacon <will.deacon@xxxxxxx> Cc: James Morse <james.morse@xxxxxxx> Cc: Bhupesh Sharma <bhsharma@xxxxxxxxxx> Cc: David Hildenbrand <david@xxxxxxxxxx> Cc: Mark Rutland <mark.rutland@xxxxxxx> Cc: Dave Kleikamp <dave.kleikamp@xxxxxxxxxx> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> Cc: Mike Rapoport <rppt@xxxxxxxxxxxxxxxxxx> Cc: Michal Hocko <mhocko@xxxxxxxx> Cc: Florian Fainelli <f.fainelli@xxxxxxxxx> Cc: Stefan Agner <stefan@xxxxxxxx> Cc: Laura Abbott <labbott@xxxxxxxxxx> Cc: Greg Hackmann <ghackmann@xxxxxxxxxxx> Cc: Johannes Weiner <hannes@xxxxxxxxxxx> Cc: Kristina Martsenko <kristina.martsenko@xxxxxxx> Cc: CHANDAN VN <chandan.vn@xxxxxxxxxxx> Cc: AKASHI Takahiro <takahiro.akashi@xxxxxxxxxx> Cc: Logan Gunthorpe <logang@xxxxxxxxxxxx> Reviewed-by: Matthias Brugger <mbrugger@xxxxxxxx> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
Acked-by: Catalin Marinas <catalin.marinas@xxxxxxx>