[PATCH] dio: Fix buffer overflow in case of unknown board

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



With gcc 8.2.0:

    drivers/dio/dio.c: In function ‘dio_init’:
    drivers/dio/dio.c:240:17: warning: ‘strcpy’ writing 69 or more bytes into a region of size 64 overflows the destination [-Wstringop-overflow=]
		     strcpy(dev->name,dio_getname(dev->id));
		     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Indeed, if an unknown board is present, the target buffer will overflow.
Shorten the unknown board name string to fix this.

Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
---
 drivers/dio/dio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dio/dio.c b/drivers/dio/dio.c
index 92e78d16b476550c..4ff65c690b04b50b 100644
--- a/drivers/dio/dio.c
+++ b/drivers/dio/dio.c
@@ -90,7 +90,7 @@ static struct dioname names[] =
 #undef DIOFBNAME
 
 static const char *unknowndioname 
-        = "unknown DIO board -- please email <linux-m68k@xxxxxxxxxxxxxxxxxxxx>!";
+	= "unknown DIO board, please email linux-m68k@xxxxxxxxxxxxxxxxxxxx";
 
 static const char *dio_getname(int id)
 {
-- 
2.17.1




[Index of Archives]     [Video for Linux]     [Yosemite News]     [Linux S/390]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux