On Mon, Jan 7, 2019 at 10:29 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
With gcc 7.3.0: arch/m68k/atari/config.c: In function ‘atari_switches_setup’: arch/m68k/atari/config.c:151:2: warning: ISO C90 forbids variable length array ‘switches’ [-Wvla] char switches[strlen(str) + 1]; ^~~~ Replace the variable size by the maximum kernel command line size (512 bytes), which is an upper limit for all suboptions. Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Seems fine as long as COMMAND_LINE_SIZE never grows a lot. Some architectures use 1024 or 2048, but m68k currently has 256 (you write 512 here). Arnd