On 10/26/18 4:07 AM, Mike Rapoport wrote:
On Thu, Oct 25, 2018 at 04:07:13PM -0700, Florian Fainelli wrote:
On 10/25/18 2:13 PM, Rob Herring wrote:
On Thu, Oct 25, 2018 at 12:30 PM Mike Rapoport <rppt@xxxxxxxxxxxxx> wrote:
On Thu, Oct 25, 2018 at 08:15:15AM -0500, Rob Herring wrote:
+Ard
On Thu, Oct 25, 2018 at 4:38 AM Mike Rapoport <rppt@xxxxxxxxxxxxx> wrote:
On Wed, Oct 24, 2018 at 02:55:17PM -0500, Rob Herring wrote:
On Wed, Oct 24, 2018 at 2:33 PM Florian Fainelli <f.fainelli@xxxxxxxxx> wrote:
Hi all,
While investigating why ARM64 required a ton of objects to be rebuilt
when toggling CONFIG_DEV_BLK_INITRD, it became clear that this was
because we define __early_init_dt_declare_initrd() differently and we do
that in arch/arm64/include/asm/memory.h which gets included by a fair
amount of other header files, and translation units as well.
I think arm64 does not have to redefine __early_init_dt_declare_initrd().
Something like this might be just all we need (completely untested,
probably it won't even compile):
[ ... ]
FWIW, I am extracting the ARM implementation that parses the initrd
early command line parameter and the "setup" code doing the page
boundary alignment and memblock checking into a helper into lib/ that
other architectures can re-use. So far, this removes the need for
unicore32, arc and arm to duplicate essentially the same logic.
Presuming you are going to need asm-generic/initrd.h for that as well,
using override for __early_init_dt_declare_initrd in arm64 version of
initrd.h might be the simplest option.
What I am contemplating doing is promote
phys_initrd_start/phys_initrd_size to be global variables (similar to
initrd_start, initrd_end) and have a generic helper function for parsing
the initrd= command line parameter and finally removing
__early_init_dt_declare_initrd() because we could have
early_init_dt_check_for_initrd() just populate
phys_initrd_start/phys_initrd_size directly as well as
initrd_start/initrd_end using __va() to preserve compatibility with
architectures that rely on this. Then I would convert ARM64 to check for
phys_initrd_start which is really what it is is trying to do in
arch/arm64/mm/init.c::arm64_memblock_init().
Does that sound like a reasonable approach?
--
Florian
