Hi Finn,
On Tue, 2 Oct 2018 at 04:22, Finn Thain <fthain@xxxxxxxxxxxxxxxxxxx> wrote:
On Mon, 1 Oct 2018, Firoz Khan wrote:
--- /dev/null
+++ b/arch/m68k/kernel/syscalls/syscallhdr.sh
@@ -0,0 +1,35 @@
+#!/bin/sh
That's not accurate. These are bash scripts, not Bourne shell.
If you run 'checkbashisms', you'll see that a few small changes are needed
in order to gain standards compliance and portability.
Sure.
Some untested suggestions:
diff --git a/arch/m68k/kernel/syscalls/syscallhdr.sh b/arch/m68k/kernel/syscalls/syscallhdr.sh
index e0e3108cfc7f..9811f82848e6 100644
--- a/arch/m68k/kernel/syscalls/syscallhdr.sh
+++ b/arch/m68k/kernel/syscalls/syscallhdr.sh
@@ -18,17 +18,17 @@ grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | (
nxt=0
while read nr abi name entry ; do
if [ -z "$offset" ]; then
- echo -e "#define __NR_${prefix}${name}\t$nr"
+ echo "#define __NR_${prefix}${name} $nr"
else
- echo -e "#define __NR_${prefix}${name}\t($offset + $nr)"
+ echo "#define __NR_${prefix}${name} ($offset + $nr)"
fi
nxt=$nr
- let nxt=nxt+1
+ nxt=$((nxt+1))
done
echo ""
echo "#ifdef __KERNEL__"
- echo -e "#define __NR_syscalls\t$nxt"
+ echo "#define __NR_syscalls $nxt"
echo "#endif"
echo ""
echo "#endif /* ${fileguard} */"
diff --git a/arch/m68k/kernel/syscalls/syscalltbl.sh b/arch/m68k/kernel/syscalls/syscalltbl.sh
index d2635dea4e96..89ab047097ce 100644
--- a/arch/m68k/kernel/syscalls/syscalltbl.sh
+++ b/arch/m68k/kernel/syscalls/syscalltbl.sh
@@ -13,7 +13,7 @@ emit() {
while [ $nxt -lt $nr ]; do
echo "__SYSCALL($nxt, sys_ni_syscall, )"
- let nxt=nxt+1
+ nxt=$((nxt+1))
done
echo "__SYSCALL($nr, $entry, )"
@@ -29,6 +29,6 @@ grep '^[0-9]' "$in" | sort -n | (
while read nr abi name entry ; do
emit $nxt $nr $entry
nxt=$nr
- let nxt=nxt+1
+ nxt=$((nxt+1))
done
) > "$out"
Thanks for your comments! I'll have a look into it.
Firoz
--
